Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed match popover position #2777

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

anderson-oki
Copy link
Collaborator

@anderson-oki anderson-oki commented Dec 2, 2024

Description

There is an issue when we force the match popover to display on the bottom and the floating-ui middleware of shift and flip does not identify the end of the viewport and the modal overflows outside of the viewport.

One of the issues is cause by a combination of the position with the ref. Replaced to use the disclosure hook instead.

@anderson-oki anderson-oki self-assigned this Dec 2, 2024
@anderson-oki anderson-oki merged commit c62afe7 into development Dec 3, 2024
2 checks passed
@anderson-oki anderson-oki deleted the fix/match-popover-position branch December 3, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant