template tag error staticfiles #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkinsella
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
I don't have the capacity to test this right now, but this change looks like the way things should be based on the Django docs and deprecation notices.
What I don't understand is why our team is able to use this fork as it stands (with the old staticfiles loaded) without issue. Maybe it's a soft deprecation?
|
And btw super cool that you contributed! Thanks @akashjadhav3 |
|
We're actually selling this error in production in our admin area today. Gonna merge here and see if fixes things. Will bump version tag to v0.22 |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of your pull request?
Proposed changes
Fixed staticfiles' is not a registered tag library.