Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewardsDistributor naming is opinionated #166

Closed
julien-devatom opened this issue Oct 6, 2023 · 2 comments · Fixed by #170
Closed

rewardsDistributor naming is opinionated #166

julien-devatom opened this issue Oct 6, 2023 · 2 comments · Fixed by #170
Assignees
@Rubilmax

Comments

@julien-devatom
Copy link
Contributor

Nothing is preventing the vault owner to not redistributing the rewards and setting an EOA or any treasury address as receiver.
That's why I suggest renaming rewardsDistributor to rewardsRecipient, just to fit exactly the scope of this address
@MerlinEgalite
Copy link
Contributor

I would agree but in practice it won't be the case so think I'm not sure we should do it. I don't have a strong opinion on it though

@julien-devatom
Copy link
Contributor Author

We don't know who is going to use the mm

@Rubilmax Rubilmax self-assigned this Oct 6, 2023
@Rubilmax Rubilmax mentioned this issue Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rubilmax Rubilmax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(rewards): rename rewardsDistributor morpho-org/metamorpho
3 participants
@Rubilmax @MerlinEgalite @julien-devatom