Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rewards): rename rewardsDistributor #170

Merged
merged 2 commits into from
Oct 6, 2023
Merged

refactor(rewards): rename rewardsDistributor #170

merged 2 commits into from
Oct 6, 2023

Conversation

Rubilmax
Copy link
Contributor

@Rubilmax Rubilmax commented Oct 6, 2023

@Rubilmax Rubilmax marked this pull request as ready for review October 6, 2023 13:50
@openzeppelin-code
Copy link

openzeppelin-code bot commented Oct 6, 2023 •
edited
Loading

refactor(rewards): rename rewardsDistributor

Generated at commit: 075d4b6f994198bf4bb1d281a418d6a9381d4df7

🚨 Vulnerabilities Summary

Process Issues Results
Contract Inspector note
low
Total		 15
5
20
Dependency Checker Total 0

For more details view the full report in OpenZeppelin Code

Jean-Grimal
Jean-Grimal approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@Jean-Grimal Jean-Grimal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I prefer rewardsDistributor because it highlights that the rewards will be redistributed

@Rubilmax
Copy link
Contributor Author

Rubilmax commented Oct 6, 2023

I think I prefer rewardsDistributor because it highlights that the rewards will be redistributed

Please check the issue linked

@Rubilmax Rubilmax merged commit 70f60d8 into main Oct 6, 2023
4 checks passed
@Rubilmax Rubilmax deleted the refactor/rename-rewards-distributor branch October 6, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@julien-devatom julien-devatom Awaiting requested review from julien-devatom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rewardsDistributor naming is opinionated
3 participants
@Rubilmax @MerlinEgalite @Jean-Grimal