Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: accrue fees on submitFee when no timelock #140

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Fix: accrue fees on submitFee when no timelock #140

merged 3 commits into from
Oct 4, 2023

Conversation

Jean-Grimal
Copy link
Contributor

@Jean-Grimal Jean-Grimal commented Oct 4, 2023 •
edited by MerlinEgalite
Loading

Fixes #299

MerlinEgalite
MerlinEgalite requested changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding! Should we move _updateLastTotalAssets in _setFee ?

MerlinEgalite
MerlinEgalite approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome let's go!

@MerlinEgalite MerlinEgalite merged commit b0d6037 into main Oct 4, 2023
6 checks passed
@MerlinEgalite MerlinEgalite deleted the fix/accrue-fees-submit-fee branch October 4, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@Rubilmax Rubilmax Rubilmax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

M-01 Unreliable Fee Accrual When Modifying Fee Values
3 participants
@Jean-Grimal @Rubilmax @MerlinEgalite