Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reallocate): prevent withdraw inconsistent asset #151

Merged
merged 1 commit into from
Oct 5, 2023
Merged

fix(reallocate): prevent withdraw inconsistent asset #151

merged 1 commit into from
Oct 5, 2023

Conversation

Rubilmax
Copy link
Contributor

@Rubilmax Rubilmax commented Oct 5, 2023

@Rubilmax Rubilmax marked this pull request as ready for review October 5, 2023 13:22
Jean-Grimal
Jean-Grimal approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@Jean-Grimal Jean-Grimal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats for this finding, it was hard to detect imo

@MerlinEgalite MerlinEgalite merged commit eaeba62 into main Oct 5, 2023
6 checks passed
@MerlinEgalite MerlinEgalite deleted the feat/withdraw-inconsistent-asset branch October 5, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@julien-devatom julien-devatom julien-devatom approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Withdraw token can be different from the ERC4626 asset
4 participants
@Rubilmax @MerlinEgalite @julien-devatom @Jean-Grimal