Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test events #192

Merged
merged 4 commits into from
Oct 12, 2023
Merged

Test events #192

merged 4 commits into from
Oct 12, 2023

Conversation

MerlinEgalite
Copy link
Contributor

@MerlinEgalite MerlinEgalite commented Oct 11, 2023 •
edited
Loading

Fixes #78
Fixes #193

@MerlinEgalite MerlinEgalite requested review from a team, Rubilmax and Jean-Grimal and removed request for a team October 11, 2023 16:07
@openzeppelin-code
Copy link

openzeppelin-code bot commented Oct 11, 2023 •
edited
Loading

Test events

Generated at commit: d9c7cee477e615dc42b39c43c23e98a8eb842c59

🚨 Vulnerabilities Summary

Process Issues Results
Contract Inspector note
low
Total		 14
5
19
Dependency Checker Total 0

For more details view the full report in OpenZeppelin Code

@MerlinEgalite MerlinEgalite marked this pull request as ready for review October 11, 2023 16:29
Jean-Grimal
Jean-Grimal approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@Jean-Grimal Jean-Grimal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MerlinEgalite MerlinEgalite merged commit cd8204b into main Oct 12, 2023
6 checks passed
@MerlinEgalite MerlinEgalite deleted the test/events branch October 12, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@Rubilmax Rubilmax Awaiting requested review from Rubilmax Rubilmax was automatically assigned from morpho-labs/onchain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing simple withdraw/redeem tests Test behavior of queues & events
2 participants
@MerlinEgalite @Jean-Grimal