Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use msgSender() #230

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Use msgSender() #230

merged 1 commit into from
Oct 20, 2023

Conversation

MerlinEgalite
Copy link
Contributor

@MerlinEgalite MerlinEgalite commented Oct 19, 2023 •
edited
Loading

Fixes #238

@MerlinEgalite MerlinEgalite requested review from QGarchery, a team, Rubilmax and Jean-Grimal and removed request for a team October 19, 2023 12:03
QGarchery
QGarchery approved these changes Oct 19, 2023 •
edited
Loading
View reviewed changes
@QGarchery
Copy link
Contributor

Should this close #223 actually ? There are other suggestions

@MerlinEgalite MerlinEgalite marked this pull request as ready for review October 19, 2023 16:18
@MerlinEgalite
Copy link
Contributor Author

Indeed I created a specific issue and updated this PR

@MerlinEgalite MerlinEgalite merged commit a63b94a into main Oct 20, 2023
6 checks passed
@MerlinEgalite MerlinEgalite deleted the refactor/quentin-suggestions branch October 20, 2023 08:40
@MerlinEgalite MerlinEgalite changed the title Refactor suggestions Use msgSender() Oct 20, 2023
@MerlinEgalite MerlinEgalite linked an issue Nov 3, 2023 that may be closed by this pull request
N-10 Inconsistent Retrieval of msg.sender #303
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@QGarchery QGarchery QGarchery approved these changes

@Rubilmax Rubilmax Rubilmax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

N-10 Inconsistent Retrieval of msg.sender choose either msgSender() or msg.sender, currently both are used
4 participants
@MerlinEgalite @QGarchery @Rubilmax @Jean-Grimal