Refactor modifiers privilege

[MerlinEgalite]

No description provided.

[Rubilmax]

or perhaps don't change anything and rely on transitivity of privileges because the hierarchy is a tree (which is what was chosen for the URD)

I was against at first because I thought for a moment hierarchy was not a tree (e.g. there was a privilege for the guardian but not the owner) but there's none

[MerlinEgalite]

or perhaps don't change anything and rely on transitivity of privileges because the hierarchy is a tree (which is what was chosen for the URD)

I was against at first because I thought for a moment hierarchy was not a tree (e.g. there was a privilege for the guardian but not the owner) but there's none

But then it's not consistent between repos...

[Rubilmax]

I don't get it, it is: https://github.com/morpho-org/universal-rewards-distributor/blob/26388ed651c0d774d74c1335c104b4a11718e3bd/src/UniversalRewardsDistributor.sol#L55

see we named it onlyUpdater and not hasUpdaterPrivilege

[MerlinEgalite]

I don't get it, it is: https://github.com/morpho-org/universal-rewards-distributor/blob/26388ed651c0d774d74c1335c104b4a11718e3bd/src/UniversalRewardsDistributor.sol#L55

see we named it onlyUpdater and not hasUpdaterPrivilege

I would rename it in the URD as well but it's under review for now.

@julien-devatom do you have a preference?

I like hasUpdaterPrivilege because it makes things clearer

[MerlinEgalite]

Other suggestion onlyCuratorRole, etc. A bit like OZ: https://docs.openzeppelin.com/contracts/4.x/access-control

[julien-devatom]

I'm ok, you can suggest this naming inside of the security review issue related to that