Update doc and natspec #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean-Grimal
requested review from
Rubilmax,
MerlinEgalite,
a team,
adhusson,
QGarchery and
MathisGD
and removed request for
a team
MerlinEgalite
requested changes
Dec 12, 2023
Co-authored-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com> Signed-off-by: Jean-Grimal <83286814+Jean-Grimal@users.noreply.github.com>
MerlinEgalite
approved these changes
Dec 12, 2023
Rubilmax
reviewed
Dec 12, 2023
MerlinEgalite
approved these changes
Dec 13, 2023
Rubilmax
approved these changes
Dec 13, 2023
Co-authored-by: Romain Milon <rmilon@gmail.com> Signed-off-by: Jean-Grimal <83286814+Jean-Grimal@users.noreply.github.com>
MerlinEgalite
approved these changes
Dec 13, 2023
Rubilmax
approved these changes
Dec 13, 2023
MerlinEgalite
approved these changes
Dec 13, 2023
Rubilmax
approved these changes
Dec 14, 2023
adhusson
approved these changes
Dec 18, 2023
QGarchery
approved these changes
Dec 22, 2023
| /// @notice Submits a forced market removal from the vault, potentially losing all funds supplied to the market. | ||
| /// @dev Warning: Submitting a forced removal will overwrite the timestamp at which the market will be removable. | ||
| /// @notice Submits a forced market removal from the vault, eventually losing all funds supplied to the market. |
There was a problem hiding this comment.
I would not change potentially into eventually, the funds will not necessarily be lost if the timelock is reached and the market effectively removed: funds could possibly be recovered later with a reallocate if the market allows it
There was a problem hiding this comment.
This will be addressed in #354 pls don't change this PR let's merge it
MathisGD
approved these changes
Dec 26, 2023
Merged
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes :