Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Stermi review #374

Merged
merged 8 commits into from
Jan 2, 2024
Merged

Fixes Stermi review #374

merged 8 commits into from
Jan 2, 2024

Conversation

MerlinEgalite
Copy link
Contributor

@MerlinEgalite MerlinEgalite commented Dec 30, 2023 •
edited by QGarchery
Loading

@MerlinEgalite MerlinEgalite requested review from a team, adhusson, Rubilmax, QGarchery, MathisGD and Jean-Grimal and removed request for a team December 30, 2023 19:20
QGarchery
QGarchery reviewed Jan 2, 2024
View reviewed changes
Copy link
Contributor

@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving (but not really because it's a draft)

README.md Outdated Show resolved Hide resolved
src/interfaces/IMetaMorpho.sol Outdated Show resolved Hide resolved
@QGarchery QGarchery mentioned this pull request Jan 2, 2024
Closed
@QGarchery QGarchery marked this pull request as ready for review January 2, 2024 10:43
MerlinEgalite
MerlinEgalite commented Jan 2, 2024
View reviewed changes
Copy link
Contributor Author

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MathisGD
MathisGD reviewed Jan 2, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
MathisGD
MathisGD reviewed Jan 2, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
Jean-Grimal
Jean-Grimal previously approved these changes Jan 2, 2024
View reviewed changes
@MerlinEgalite @MathisGD
docs: apply suggestions
bc9dfbe 
Co-authored-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
Signed-off-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com>
@MerlinEgalite MerlinEgalite merged commit 0e036c6 into post-cantina Jan 2, 2024
6 checks passed
@MerlinEgalite MerlinEgalite deleted the fix/stermi-review branch January 2, 2024 18:43
Rubilmax
Rubilmax reviewed Jan 8, 2024
View reviewed changes
Copy link
Contributor

@Rubilmax Rubilmax left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

MathisGD
MathisGD reviewed Jan 16, 2024
View reviewed changes
Copy link
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathisGD MathisGD MathisGD approved these changes

@Rubilmax Rubilmax Rubilmax left review comments

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@QGarchery QGarchery QGarchery approved these changes

@StErMi StErMi StErMi approved these changes

@adhusson adhusson Awaiting requested review from adhusson adhusson was automatically assigned from morpho-org/onchain-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MerlinEgalite @StErMi @Rubilmax @QGarchery @MathisGD @Jean-Grimal