Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update foundry v1.0 #437

Merged
merged 15 commits into from
Feb 25, 2025
Merged

Update foundry v1.0 #437

merged 15 commits into from
Feb 25, 2025

Conversation

QGarchery
Copy link
Contributor

@QGarchery QGarchery commented Feb 14, 2025 •
edited
Loading

Also update libs:

  • forge-std to latest version, to use expectPartial match
  • morpho-blue to latest version (avoid license warning, and add latest test and verif changes)
  • erc4626-test as they used the testFail pattern before update

Also remove timestamps in munging patch

@QGarchery QGarchery requested a review from a team February 14, 2025 10:01
@QGarchery QGarchery self-assigned this Feb 14, 2025
@QGarchery QGarchery requested review from adhusson, peyha, MathisGD, MattLsb and colin-morpho and removed request for a team February 14, 2025 10:01
MathisGD
MathisGD reviewed Feb 18, 2025
View reviewed changes
MathisGD
MathisGD reviewed Feb 18, 2025
View reviewed changes
Copy link
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change changes the compiled bytecode (because we still have the metadata in this repo). Should we at least remove the metadata?

@QGarchery QGarchery mentioned this pull request Feb 24, 2025
Open
@adhusson adhusson self-requested a review February 24, 2025 15:53
MathisGD
MathisGD reviewed Feb 24, 2025
View reviewed changes
MathisGD
MathisGD approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified that it doesn't modify the bytecode (if we remove the metadata on main as well)

@QGarchery QGarchery merged commit 543dbbd into main Feb 25, 2025
20 checks passed
@QGarchery QGarchery deleted the fix/update-foundry-v1.0 branch February 25, 2025 08:58
@QGarchery QGarchery mentioned this pull request Feb 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhusson adhusson adhusson approved these changes

@MathisGD MathisGD MathisGD approved these changes

@colin-morpho colin-morpho colin-morpho approved these changes

@peyha peyha Awaiting requested review from peyha peyha was automatically assigned from morpho-org/protocol-team

@MattLsb MattLsb Awaiting requested review from MattLsb MattLsb was automatically assigned from morpho-org/protocol-team

Assignees

@QGarchery QGarchery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QGarchery @adhusson @MathisGD @colin-morpho