-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wrapper bundler #309
Add wrapper bundler #309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a general note, I think it'd be clearer to have a draft implementation
You talked about a repository, is it existing?
Do we have a clear usecase described as follows:
- I am an EOA, I want to bundle deposits/withdrawals through the bundler
- Do I want to deposit on behalf of another protocol/EOA?
- Should I transfer anything to the bundler? To somewhere else?
- Who is authorized to do what on the permission wrapper?
I'll try to setup the repo this week but it's not my prio yet.
Let's say I'm an EOA:
That makes me think that there's a pb at step 2 in this PR I think |
The rationale for this user would be: I prefer to interact with permissioned tokens to avoid touching securities right? |
It's for these reasons for example EDIT: the link was missing sorry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I overall feel like OZ's ERC20Wrapper
is poorly maintained and not standardized so I'd instead advocate to define our own (including the feature to withdraw on behalf of someone else, provided you are given enough allowance)
Obviously there are features that are not possible for regulatory reasons but I think this workshop deserves a design call. Can we plan one?
What leads you to say that? Overall agree with the rest. I think it's quite easy to adapt the code to our needs |
6bde5b8
to
7b16d8f
Compare
…dlers into feat/wrapper
…undlers into feat/wrapper
…o-blue-bundlers into feat/wrapper
Add wrapper bundler
🚨 Vulnerabilities Summary
For more details view the full report in OpenZeppelin Code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems correct but I need to review it with underlying PRs merged to make sure we're not missing a change
Fixes #292