feat(morpho): protect from slippage #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Rubilmax
commented
Oct 23, 2023
•
Rubilmax
commented
- Fixes https://github.com/cantinasec/review-morpho-blue-1/issues/33
- Fixes M-03 Bundler Slippage May Cause Unexpected Loss of Funds #344
Co-authored-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com> Signed-off-by: Jean-Grimal <83286814+Jean-Grimal@users.noreply.github.com>
Co-authored-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com> Signed-off-by: Jean-Grimal <83286814+Jean-Grimal@users.noreply.github.com>
…of github.com:morpho-labs/morpho-stack into feat/async-slippage-protection
Rubilmax
requested review from
QGarchery,
MerlinEgalite,
oumar-fall,
julien-devatom,
MathisGD and
Jean-Grimal
Rubilmax
changed the base branch from
review-cantina
to
feat/async-slippage-protection
Rubilmax
changed the title
Jean-Grimal
approved these changes
Oct 23, 2023
…to feat/async-slippage-protection
…bs/morpho-stack into feat/morpho-slippage-protection
Rubilmax
force-pushed
the
feat/async-slippage-protection
branch
from
3ea66a7
to
4e7913e
Compare
…bs/morpho-stack into feat/morpho-slippage-protection
|
Are all those commits necessary? 👀 |
They are due to the mix between rebase & merge |
Jean-Grimal
approved these changes
Oct 24, 2023
MerlinEgalite
approved these changes
Oct 24, 2023
QGarchery
reviewed
Oct 25, 2023
QGarchery
approved these changes
Oct 26, 2023
…bs/morpho-blue-bundlers into feat/morpho-slippage-protection
…bs/morpho-blue-bundlers into feat/morpho-slippage-protection
MerlinEgalite
requested review from
QGarchery,
Jean-Grimal and
julien-devatom
Base automatically changed from
feat/async-slippage-protection
to
review-cantina
October 31, 2023 08:31
Jean-Grimal
reviewed
Oct 31, 2023
|
This PR should not be merged yet |
julien-devatom
approved these changes
Oct 31, 2023
…undlers into feat/morpho-slippage-protection
feat(morpho): protect from slippage
🚨 Vulnerabilities Summary
For more details view the full report in OpenZeppelin Code |
…undlers into feat/morpho-slippage-protection
StErMi
reviewed
Nov 4, 2023
| /// @param shares The amount of shares to burn. | ||
| /// @param slippageAmount The minimum amount of shares to mint in exchange for `assets` when it is used. |
There was a problem hiding this comment.
error: shares are burned in withdraw and not minted
StErMi
reviewed
Nov 4, 2023
| /// @notice Warning: should only be called via the bundler's `multicall` function. | ||
| /// @dev Either `assets` or `shares` should be zero. Most usecases should rely on `assets` as an input so the | ||
| /// initiator is guaranteed to withdraw `assets` tokens, but the possibility to mint a specific amount of shares is |
There was a problem hiding this comment.
error: shares are burned in withdraw and not minted
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.