Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(bundlers): add reentrancy disclosure #315

Merged
merged 5 commits into from
Oct 31, 2023
Merged

docs(bundlers): add reentrancy disclosure #315

merged 5 commits into from
Oct 31, 2023

Conversation

Rubilmax
Copy link
Collaborator

@Rubilmax Rubilmax marked this pull request as ready for review October 23, 2023 14:39
MerlinEgalite
MerlinEgalite requested changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing contracts i think:

  • WNativeBundler
  • Permit2Bundler with permit.permitted.token

@Rubilmax
Copy link
Collaborator Author

Rubilmax commented Oct 23, 2023 •
edited
Loading

Missing contracts i think:

  • WNativeBundler
  • Permit2Bundler with permit.permitted.token

Where is the reentrancy in WNativeBundler? WRAPPED_NATIVE is known

@MerlinEgalite
Copy link
Contributor

Where is the reentrancy in WNativeBundler? WRAPPED_NATIVE is known

Agree

@Rubilmax Rubilmax force-pushed the feat/prevent-nested-multicall branch 2 times, most recently from 828405a to 28fdcfb Compare October 24, 2023 12:54
@Rubilmax Rubilmax mentioned this pull request Oct 24, 2023
Merged
@QGarchery QGarchery changed the title docs(bundlers): add reetrancy disclosure docs(bundlers): add reentrancy disclosure Oct 25, 2023
@Rubilmax Rubilmax self-assigned this Oct 26, 2023
Base automatically changed from feat/prevent-nested-multicall to review-cantina October 30, 2023 16:58
Rubilmax
Rubilmax commented Oct 30, 2023
View reviewed changes
Copy link
Collaborator Author

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested

src/ERC4626Bundler.sol Outdated Show resolved Hide resolved
Rubilmax
Rubilmax commented Oct 31, 2023
View reviewed changes
src/PermitBundler.sol Outdated Show resolved Hide resolved
Rubilmax
Rubilmax commented Oct 31, 2023
View reviewed changes
Copy link
Collaborator Author

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Rubilmax
Rubilmax commented Oct 31, 2023
View reviewed changes
Copy link
Collaborator Author

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rubilmax Rubilmax merged commit 97bab2b into review-cantina Oct 31, 2023
8 checks passed
@Rubilmax Rubilmax deleted the docs/reentrancy branch October 31, 2023 09:52
@MerlinEgalite MerlinEgalite mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@QGarchery QGarchery Awaiting requested review from QGarchery

@MathisGD MathisGD Awaiting requested review from MathisGD

Assignees

@Rubilmax Rubilmax

Labels
☑️ lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rubilmax @MerlinEgalite @Jean-Grimal