Fix/complete-natspec-issue-17

[Jean-Grimal]

Fixes https://github.com/cantinasec/review-morpho-blue-1/issues/17

[MerlinEgalite]

I think @Rubilmax you must update some of your PRs to point to this one right?

[Rubilmax]

Why did you change the branch? Couldn't we continue working on the other?

[MerlinEgalite]

Why did you change the branch? Couldn't we continue working on the other?

The other one was polluted with many commits (idk really know why). I suggested a rebase but @Jean-Grimal opted for this solution which works also.

[Rubilmax]

Why did you change the branch? Couldn't we continue working on the other?

The other one was polluted with many commits (idk really know why). I suggested a rebase but @Jean-Grimal opted for this solution which works also.

Indeed it also works, but it nullifies the work I did to base my work on the previous branch, so I can't support this
The former branch doesn't contain "dead" commit or any weird-looking commit, so I don't get the rationale either

I'll merge this branch into the previous branch to see how it looks and if it looks fine I prefer to still work on the previous branch, which avoids to duplicate my work

[Rubilmax]

See #302: what's the issue?

If there's none, pls close this PR and move back to the previous branch which I just updated with this work

[Jean-Grimal]

See #302: what's the issue?

If there's none, pls close this PR and move back to the previous branch which I just updated with this work

It looks fine. Actually I just didn't have enough git skills, that's why I created a new branch.
I didn't know that you based you work on the previous branch sorry.

[MerlinEgalite]

See #302: what's the issue?

If there's none, pls close this PR and move back to the previous branch which I just updated with this work

The issue was before, perhaps a missing merge?

see below

[Rubilmax]

Alright, then it's all sorted out!