refactor(migration): remove unnecessary network-specific instanciation #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing... |
Rubilmax
force-pushed
the
refactor/migration-constructor
branch
from
2eebb28
to
90ef4bd
Compare
|
Tests are failing |
and i don't know why... |
…into refactor/migration-constructor
Rubilmax
commented
Oct 31, 2023
| import {MigrationBundler, ERC20} from "./MigrationBundler.sol"; | ||
|
|
||
| /// @title AaveV2MigrationBundler | ||
| /// @author Morpho Labs | ||
| /// @custom:contact security@morpho.org | ||
| /// @notice Contract allowing to migrate a position from Aave V2 to Morpho Blue easily. | ||
| /// If deploying to Ethereum, deploy `AaveV2EthereumMigrationBundler` instead. | ||
| contract AaveV2MigrationBundler is MigrationBundler { | ||
| contract AaveV2MigrationBundler is MigrationBundler, StEthBundler { |
There was a problem hiding this comment.
So the goal of this PR is to harmonize things: either have all migration bundlers instances defined in ethereum, or have no migration bundler defined in ethereum
The previous state where only the AaveV2 migration bundler was defined with its parameters as constants is inconsistent with other migration bundlers
Jean-Grimal
approved these changes
Oct 31, 2023
…into refactor/migration-constructor
|
rerunning jobs |
There was a problem hiding this comment.
Should we rename this file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AaveV2MigrationBundler&CompoundV2MigrationBundlerare not abstract #304So I first went to make migration bundlers abstract and re-instanciate them in
ethereumfolder but it's simpler to check the address in the constructor or simply don't check anything so I removedAaveV2EthereumMigrationBundler