-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cantina review #338
Merged
Merged
Cantina review #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com> Signed-off-by: Jean-Grimal <83286814+Jean-Grimal@users.noreply.github.com>
Co-authored-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com> Signed-off-by: Jean-Grimal <83286814+Jean-Grimal@users.noreply.github.com>
update `review-cantina`
…of github.com:morpho-labs/morpho-stack into feat/async-slippage-protection
…to feat/async-slippage-protection
…bs/morpho-stack into feat/morpho-slippage-protection
Update `review-cantina` with hardhat tests
fix(goerli): add transfer bundler
fix(receive): don't prevent receiving raw ETH
Refactor erc4626 approval to infinite
Remove useless Math import
…into feat/only-initiated
…tack into fix/prevent-reentrancy
…tack into fix/prevent-reentrancy
Fix: Typographical Errors bundler - issue n 07
docs(morpho): fix natspecs
feat(protect): add onlyInitiated modifier
…into fix/prevent-reentrancy
ci(cred): remove app auth
build(lib): remove morpho-blue-irm
…into fix/prevent-reentrancy
refactor(modifier): protect all functions
Rubilmax
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how to be relevant on such a large PR review, but I think the changes are relevant to cantina's review and they do not miss any issue raised
Rubilmax
reviewed
Nov 8, 2023
ci(foundry): decrease fuzz runs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.