Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cantina review #338

Merged
merged 154 commits into from
Nov 8, 2023
Merged

Cantina review #338

merged 154 commits into from
Nov 8, 2023

Conversation

MerlinEgalite
Copy link
Contributor

No description provided.

Jean-Grimal and others added 30 commits October 18, 2023 15:10
Co-authored-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com>
Signed-off-by: Jean-Grimal <83286814+Jean-Grimal@users.noreply.github.com>
Co-authored-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com>
Signed-off-by: Jean-Grimal <83286814+Jean-Grimal@users.noreply.github.com>
…of github.com:morpho-labs/morpho-stack into feat/async-slippage-protection
…bs/morpho-stack into feat/morpho-slippage-protection
Update `review-cantina` with hardhat tests
Rubilmax and others added 23 commits November 3, 2023 16:41
fix(goerli): add transfer bundler
fix(receive): don't prevent receiving raw ETH
Fix: Typographical Errors bundler - issue n 07
feat(protect): add onlyInitiated modifier
build(lib): remove morpho-blue-irm
refactor(modifier): protect all functions
@MerlinEgalite MerlinEgalite marked this pull request as ready for review November 8, 2023 14:49
Copy link
Collaborator

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to be relevant on such a large PR review, but I think the changes are relevant to cantina's review and they do not miss any issue raised

@MerlinEgalite MerlinEgalite merged commit 345311b into main Nov 8, 2023
8 checks passed
@MerlinEgalite MerlinEgalite deleted the review-cantina branch November 8, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants