-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post cantina #392
Merged
Merged
Post cantina #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `post-cantina`
Co-authored-by: Jean-Grimal <83286814+Jean-Grimal@users.noreply.github.com> Signed-off-by: Romain Milon <rmilon@gmail.com>
fix(config): set build config
feat(bundler): add Sepolia bundler
fix: remove inconsistent comment
MerlinEgalite
requested review from
a team,
adhusson,
Rubilmax and
QGarchery
and removed request for
a team
December 20, 2023 13:00
…to fix/slippage-param
…into docs/max-uint256
…into docs/max-uint256
…to docs/migration
…into docs/max-uint256
fix(erc4626): adapts slippage
…into docs/max-uint256
fix(migration): fix how repay work
…to docs/max-uint256
Specify `type(uint256).max` behaviors
feat: remove liquidate
Rubilmax
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains:
maxMint
,maxDeposit
,maxWithdraw
,maxRedeem
(call tomaxDeposit
could be avoided #378)payable
modifier inERC20WrapperBundler
(#99, #100)_approveMaxTo
in StEthBundler #385StEthBundler
(#98)type(uint256).max
behaviors #394liquidate
feature from the bundler (Remove theliquidate
on Morpho feature #374)