Specify type(uint256).max behaviors

src/ERC20WrapperBundler.sol

@@ -25,8 +25,7 @@ abstract contract ERC20WrapperBundler is BaseBundler {
     /// @dev Initiator must have previously transferred their tokens to the bundler.
     /// @dev Assumes that `wrapper` implements the `ERC20Wrapper` interface.
     /// @param wrapper The address of the ERC20 wrapper contract.
-    /// @param amount The amount of underlying tokens to deposit. Pass `type(uint256).max` to deposit the bundler's
-    /// balance.
+    /// @param amount The amount of underlying tokens to deposit. Capped at the bundler's balance.
     function erc20WrapperDepositFor(address wrapper, uint256 amount) external payable protected {
         ERC20 underlying = ERC20(address(ERC20Wrapper(wrapper).underlying()));
 
@@ -43,7 +42,7 @@ abstract contract ERC20WrapperBundler is BaseBundler {
     /// @dev Assumes that `wrapper` implements the `ERC20Wrapper` interface.
     /// @param wrapper The address of the ERC20 wrapper contract.
     /// @param account The address receiving the underlying tokens.
-    /// @param amount The amount of wrapped tokens to burn. Pass `type(uint256).max` to burn the bundler's balance.
+    /// @param amount The amount of wrapped tokens to burn. Capped at the bundler's balance.
     function erc20WrapperWithdrawTo(address wrapper, address account, uint256 amount) external payable protected {
         require(account != address(0), ErrorsLib.ZERO_ADDRESS);
 

src/ERC4626Bundler.sol

@@ -44,7 +44,7 @@ abstract contract ERC4626Bundler is BaseBundler {
     /// @dev Initiator must have previously transferred their assets to the bundler.
     /// @dev Assumes the given `vault` implements EIP-4626.
     /// @param vault The address of the vault.
-    /// @param assets The amount of assets to deposit. Pass `type(uint256).max` to deposit the bundler's assets.
+    /// @param assets The amount of assets to deposit. Capped at the bundler's assets.
     /// @param minShares The minimum amount of shares to mint in exchange for `assets`.
     /// @param receiver The address to which shares will be minted.
     function erc4626Deposit(address vault, uint256 assets, uint256 minShares, address receiver)
@@ -94,7 +94,7 @@ abstract contract ERC4626Bundler is BaseBundler {
     /// @notice Redeems the given amount of `shares` from the given ERC4626 `vault`, transferring assets to `receiver`.
     /// @dev Assumes the given `vault` implements EIP-4626.
     /// @param vault The address of the vault.
-    /// @param shares The amount of shares to burn. Pass `type(uint256).max` to redeem the bundler's shares.
+    /// @param shares The amount of shares to burn. Capped at the owner's shares.
     /// @param minAssets The minimum amount of assets to withdraw in exchange for `shares`.
     /// @param receiver The address that will receive the withdrawn assets.
     /// @param owner The address on behalf of which the shares are redeemed. Can only be the bundler or the initiator.

src/Permit2Bundler.sol

@@ -38,8 +38,7 @@ abstract contract Permit2Bundler is BaseBundler {
 
     /// @notice Transfers the given `amount` of `asset` from the initiator to the bundler via Permit2.
     /// @param asset The address of the ERC20 token to transfer.
-    /// @param amount The amount of `asset` to transfer from the initiator. Pass `type(uint256).max` to transfer the
-    /// initiator's balance.
+    /// @param amount The amount of `asset` to transfer from the initiator. Capped at the initiator's balance.
     function transferFrom2(address asset, uint256 amount) external payable protected {
         address _initiator = initiator();
         amount = Math.min(amount, ERC20(asset).balanceOf(_initiator));

src/StEthBundler.sol

@@ -41,7 +41,7 @@ abstract contract StEthBundler is BaseBundler {
     /// @notice Stakes the given `amount` of ETH via Lido, using the `referral` id.
     /// @notice stETH tokens are received by the bundler and should be used afterwards.
     /// @dev Initiator must have previously transferred their ETH to the bundler.
-    /// @param amount The amount of ETH to stake. Pass `type(uint256).max` to stake all.
+    /// @param amount The amount of ETH to stake. Capped at the bundler's ETH balance.
     /// @param minShares The minimum amount of shares to mint in exchange for `amount`.
     /// @param referral The address of the referral regarding the Lido Rewards-Share Program.
     function stakeEth(uint256 amount, uint256 minShares, address referral) external payable protected {
@@ -56,7 +56,7 @@ abstract contract StEthBundler is BaseBundler {
     /// @notice Wraps the given `amount` of stETH to wstETH.
     /// @notice wstETH tokens are received by the bundler and should be used afterwards.
     /// @dev Initiator must have previously transferred their stETH tokens to the bundler.
-    /// @param amount The amount of stEth to wrap. Pass `type(uint256).max` to wrap all.
+    /// @param amount The amount of stEth to wrap. Capped at the bundler's stETH balance.
     function wrapStEth(uint256 amount) external payable protected {
         amount = Math.min(amount, ERC20(ST_ETH).balanceOf(address(this)));
 
@@ -68,7 +68,7 @@ abstract contract StEthBundler is BaseBundler {
     /// @notice Unwraps the given `amount` of wstETH to stETH.
     /// @notice stETH tokens are received by the bundler and should be used afterwards.
     /// @dev Initiator must have previously transferred their wstETH tokens to the bundler.
-    /// @param amount The amount of wstEth to unwrap. Pass `type(uint256).max` to unwrap all.
+    /// @param amount The amount of wstEth to unwrap. Capped at the bundler's wstETH balance.
     function unwrapStEth(uint256 amount) external payable protected {
         amount = Math.min(amount, ERC20(WST_ETH).balanceOf(address(this)));
 

src/TransferBundler.sol

@@ -21,8 +21,7 @@ abstract contract TransferBundler is BaseBundler {
     /// bundler to `recipient`.
     /// @dev If the minimum happens to be zero, the transfer is silently skipped.
     /// @param recipient The address that will receive the native tokens.
-    /// @param amount The amount of native tokens to transfer. Pass `type(uint256).max` to transfer
-    /// the initiator's balance.
+    /// @param amount The amount of native tokens to transfer. Capped at the bundler's balance.
     function nativeTransfer(address recipient, uint256 amount) external payable protected {
         require(recipient != address(0), ErrorsLib.ZERO_ADDRESS);
         require(recipient != address(this), ErrorsLib.BUNDLER_ADDRESS);
@@ -39,7 +38,7 @@ abstract contract TransferBundler is BaseBundler {
     /// @dev If the minimum happens to be zero, the transfer is silently skipped.
     /// @param asset The address of the ERC20 token to transfer.
     /// @param recipient The address that will receive the tokens.
-    /// @param amount The amount of `asset` to transfer. Pass `type(uint256).max` to transfer the bundler's balance.
+    /// @param amount The amount of `asset` to transfer. Capped at the bundler's balance.
     function erc20Transfer(address asset, address recipient, uint256 amount) external payable protected {
         require(recipient != address(0), ErrorsLib.ZERO_ADDRESS);
         require(recipient != address(this), ErrorsLib.BUNDLER_ADDRESS);
@@ -54,8 +53,7 @@ abstract contract TransferBundler is BaseBundler {
     /// @notice Transfers the given `amount` of `asset` from sender to this contract via ERC20 transferFrom.
     /// @notice User must have given sufficient allowance to the Bundler to spend their tokens.
     /// @param asset The address of the ERC20 token to transfer.
-    /// @param amount The amount of `asset` to transfer from the initiator. Pass `type(uint256).max` to transfer the
-    /// initiator's balance.
+    /// @param amount The amount of `asset` to transfer from the initiator. Capped at the initiator's balance.
     function erc20TransferFrom(address asset, uint256 amount) external payable protected {
         address _initiator = initiator();
         amount = Math.min(amount, ERC20(asset).balanceOf(_initiator));

src/WNativeBundler.sol

@@ -43,7 +43,7 @@ abstract contract WNativeBundler is BaseBundler {
     /// @notice Wraps the given `amount` of the native token to wNative.
     /// @notice Wrapped native tokens are received by the bundler and should be used afterwards.
     /// @dev Initiator must have previously transferred their native tokens to the bundler.
-    /// @param amount The amount of native token to wrap. Pass `type(uint256).max` to wrap all.
+    /// @param amount The amount of native token to wrap. Capped at the bundler's native token balance.
     function wrapNative(uint256 amount) external payable protected {
         amount = Math.min(amount, address(this).balance);
 
@@ -55,7 +55,7 @@ abstract contract WNativeBundler is BaseBundler {
     /// @notice Unwraps the given `amount` of wNative to the native token.
     /// @notice Unwrapped native tokens are received by the bundler and should be used afterwards.
     /// @dev Initiator must have previously transferred their wrapped native tokens to the bundler.
-    /// @param amount The amount of wrapped native token to unwrap. Pass `type(uint256).max` to unwrap all.
+    /// @param amount The amount of wrapped native token to unwrap. Capped at the bundler's wNative balance.
     function unwrapNative(uint256 amount) external payable protected {
         amount = Math.min(amount, ERC20(WRAPPED_NATIVE).balanceOf(address(this)));
 

src/migration/AaveV2MigrationBundler.sol

@@ -37,12 +37,10 @@ contract AaveV2MigrationBundler is MigrationBundler, StEthBundler {
     /// @notice Repays `amount` of `asset` on AaveV2, on behalf of the initiator.
     /// @dev Initiator must have previously transferred their assets to the bundler.
     /// @param asset The address of the token to repay.
-    /// @param amount The amount of `asset` to repay. Pass `type(uint256).max - 1` to repay the initiator's debt and
-    /// interest. Otherwise, this parameter is capped at the maximum repayable debt.
+    /// @param amount The amount of `asset` to repay. Capped at the maximum repayable debt.
     /// @param interestRateMode The interest rate mode of the position.
     function aaveV2Repay(address asset, uint256 amount, uint256 interestRateMode) external payable protected {
-        // Use `type(uint256).max - 1` because AaveV2 prevents repaying on behalf using `type(uint256).max`.
-        if (amount != type(uint256).max - 1) amount = Math.min(amount, ERC20(asset).balanceOf(address(this)));
+        amount = Math.min(amount, ERC20(asset).balanceOf(address(this)));
 
         require(amount != 0, ErrorsLib.ZERO_AMOUNT);
 

src/migration/AaveV3MigrationBundler.sol

@@ -34,12 +34,10 @@ contract AaveV3MigrationBundler is MigrationBundler {
     /// @notice Repays `amount` of `asset` on AaveV3, on behalf of the initiator.
     /// @dev Initiator must have previously transferred their assets to the bundler.
     /// @param asset The address of the token to repay.
-    /// @param amount The amount of `asset` to repay. Pass `type(uint256).max - 1` to repay the initiator's debt and
-    /// interest. Otherwise, this parameter is capped at the maximum repayable debt.
+    /// @param amount The amount of `asset` to repay. Capped at the maximum repayable debt.
     /// @param interestRateMode The interest rate mode of the position.
     function aaveV3Repay(address asset, uint256 amount, uint256 interestRateMode) external payable protected {
-        // Use `type(uint256).max - 1` because AaveV3 prevents repaying on behalf using `type(uint256).max`.
-        if (amount != type(uint256).max - 1) amount = Math.min(amount, ERC20(asset).balanceOf(address(this)));
+        amount = Math.min(amount, ERC20(asset).balanceOf(address(this)));
 
         require(amount != 0, ErrorsLib.ZERO_AMOUNT);
 

src/migration/AaveV3OptimizerMigrationBundler.sol

@@ -34,10 +34,9 @@ contract AaveV3OptimizerMigrationBundler is MigrationBundler {
     /// @notice Repays `amount` of `underlying` on the AaveV3 Optimizer, on behalf of the initiator.
     /// @dev Initiator must have previously transferred their assets to the bundler.
     /// @param underlying The address of the underlying asset to repay.
-    /// @param amount The amount of `underlying` to repay. Pass `type(uint256).max - 1` to repay the maximum repayable
-    /// debt. Pass `type(uint256).max` to repay the initiator's debt and interest.
+    /// @param amount The amount of `underlying` to repay. Capped at the maximum repayable debt.
     function aaveV3OptimizerRepay(address underlying, uint256 amount) external payable protected {
-        if (amount != type(uint256).max) amount = Math.min(amount, ERC20(underlying).balanceOf(address(this)));
+        amount = Math.min(amount, ERC20(underlying).balanceOf(address(this)));
 
         require(amount != 0, ErrorsLib.ZERO_AMOUNT);
 

src/migration/CompoundV2MigrationBundler.sol

@@ -37,10 +37,7 @@ contract CompoundV2MigrationBundler is WNativeBundler, MigrationBundler {
     /// @notice Repays `amount` of `cToken`'s underlying asset, on behalf of the initiator.
     /// @dev Initiator must have previously transferred their assets to the bundler.
     /// @param cToken The address of the cToken contract
-    /// @param amount The amount of `cToken` to repay.
-    /// Pass `type(uint256).max - 1` to repay the maximum repayable debt (except for cETH).
-    /// Pass `type(uint256).max` to repay the initiator's debt and interest (except for cETH).
-    /// For cETH, pass `type(uint256).max` to repay the maximum repayable debt.
+    /// @param amount The amount of `cToken` to repay. Capped at the maximum repayable debt.
     function compoundV2Repay(address cToken, uint256 amount) external payable protected {
         address _initiator = initiator();
 
@@ -54,10 +51,8 @@ contract CompoundV2MigrationBundler is WNativeBundler, MigrationBundler {
         } else {
             address underlying = ICToken(cToken).underlying();
 
-            if (amount != type(uint256).max) {
-                amount = Math.min(amount, ERC20(underlying).balanceOf(address(this)));
-                amount = Math.min(amount, ICToken(cToken).borrowBalanceCurrent(_initiator));
-            }
+            amount = Math.min(amount, ERC20(underlying).balanceOf(address(this)));
+            amount = Math.min(amount, ICToken(cToken).borrowBalanceCurrent(_initiator));
 
             require(amount != 0, ErrorsLib.ZERO_AMOUNT);
 

src/migration/CompoundV3MigrationBundler.sol

@@ -24,18 +24,13 @@ contract CompoundV3MigrationBundler is MigrationBundler {
     /// @dev Initiator must have previously transferred their assets to the bundler.
     /// @dev Assumes the given `instance` is a CompoundV3 instance.
     /// @param instance The address of the CompoundV3 instance to call.
-    /// @param amount The amount of `asset` to repay. Pass `type(uint256).max - 1` to repay the maximum repayable debt.
-    /// Pass `type(uint256).max` to repay the initiator's debt and interest.
+    /// @param amount The amount of `asset` to repay. Capped at the maximum repayable debt.
     function compoundV3Repay(address instance, uint256 amount) external payable protected {
         address _initiator = initiator();
         address asset = ICompoundV3(instance).baseToken();
 
-        if (amount == type(uint256).max) {
-            amount = ICompoundV3(instance).borrowBalanceOf(_initiator);
-        } else {
-            amount = Math.min(amount, ERC20(asset).balanceOf(address(this)));
-            amount = Math.min(amount, ICompoundV3(instance).borrowBalanceOf(_initiator));
-        }
+        amount = Math.min(amount, ERC20(asset).balanceOf(address(this)));
+        amount = Math.min(amount, ICompoundV3(instance).borrowBalanceOf(_initiator));
 
         require(amount != 0, ErrorsLib.ZERO_AMOUNT);
 

test/forge/ethereum/migration/AaveV2MigrationBundlerEthereumTest.sol

@@ -115,7 +115,7 @@ contract AaveV2MigrationBundlerEthereumTest is EthereumMigrationTest {
         callbackBundle.push(_morphoBorrow(marketParams, borrowed, 0, type(uint256).max, address(bundler)));
         callbackBundle.push(_morphoSetAuthorizationWithSig(privateKey, false, 1, false));
         callbackBundle.push(_aaveV2Repay(marketParams.loanToken, borrowed / 2));
-        callbackBundle.push(_aaveV2Repay(marketParams.loanToken, type(uint256).max - 2));
+        callbackBundle.push(_aaveV2Repay(marketParams.loanToken, type(uint256).max));
         callbackBundle.push(_approve2(privateKey, aToken, uint160(aTokenBalance), 0, false));
         callbackBundle.push(_transferFrom2(aToken, aTokenBalance));
         callbackBundle.push(_aaveV2Withdraw(DAI, collateralSupplied));
@@ -129,26 +129,6 @@ contract AaveV2MigrationBundlerEthereumTest is EthereumMigrationTest {
         _assertBorrowerPosition(sDaiAmount, borrowed, user, address(bundler));
     }
 
-    function testRepayMaxInsufficientFunds(uint256 amount) public {
-        _provideLiquidity(borrowed);
-
-        deal(DAI, USER, collateralSupplied);
-
-        vm.startPrank(USER);
-        ERC20(DAI).safeApprove(AAVE_V2_POOL, collateralSupplied);
-        IAaveV2(AAVE_V2_POOL).deposit(DAI, collateralSupplied, USER, 0);
-        IAaveV2(AAVE_V2_POOL).borrow(marketParams.loanToken, borrowed, RATE_MODE, 0, USER);
-        vm.stopPrank();
-
-        bundle.push(_aaveV2Repay(marketParams.loanToken, type(uint256).max - 1));
-
-        deal(WETH, address(bundler), bound(amount, 0, borrowed - 1));
-
-        vm.expectRevert(bytes("SafeERC20: low-level call failed"));
-        vm.prank(USER);
-        bundler.multicall(bundle);
-    }
-
     function testMigrateStEthPositionWithPermit2(uint256 privateKey) public {
         address user;
         (privateKey, user) = _boundPrivateKey(privateKey);

test/forge/ethereum/migration/AaveV3MigrationBundlerEthereumTest.sol

@@ -79,26 +79,6 @@ contract AaveV3MigrationBundlerEthereumTest is EthereumMigrationTest {
         _assertBorrowerPosition(collateralSupplied, borrowed, user, address(bundler));
     }
 
-    function testRepayMaxInsufficientFunds(uint256 amount) public {
-        _provideLiquidity(borrowed);
-
-        deal(marketParams.collateralToken, USER, collateralSupplied);
-
-        vm.startPrank(USER);
-        ERC20(marketParams.collateralToken).safeApprove(AAVE_V3_POOL, collateralSupplied);
-        IAaveV3(AAVE_V3_POOL).deposit(marketParams.collateralToken, collateralSupplied, USER, 0);
-        IAaveV3(AAVE_V3_POOL).borrow(marketParams.loanToken, borrowed, RATE_MODE, 0, USER);
-        vm.stopPrank();
-
-        bundle.push(_aaveV3Repay(marketParams.loanToken, type(uint256).max - 1));
-
-        deal(marketParams.loanToken, address(bundler), bound(amount, 0, borrowed - 1));
-
-        vm.expectRevert(bytes("call failed"));
-        vm.prank(USER);
-        bundler.multicall(bundle);
-    }
-
     function testMigrateBorrowerWithPermit2(uint256 privateKey) public {
         address user;
         (privateKey, user) = _boundPrivateKey(privateKey);