Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checks in ERC20WrapperBundler #398

Merged
merged 6 commits into from
Dec 28, 2023
Merged

Add checks in ERC20WrapperBundler #398

merged 6 commits into from
Dec 28, 2023

Conversation

Jean-Grimal
Copy link
Contributor

@Jean-Grimal Jean-Grimal requested review from a team, adhusson, Rubilmax, QGarchery, MerlinEgalite and MathisGD and removed request for a team December 27, 2023 14:07
Rubilmax
Rubilmax reviewed Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Is it a real issue though? We could argue the implementation of ERC20WrapperBundler is not compatible with non-reverting ERC20Wrapper implementations and it could be fine. do we know of wrappers that don't revert and instead return false?

The cost of such a late change gets worse and worse as time goes... We are a couple of weeks away from deployment

@MerlinEgalite
Copy link
Contributor

Code looks good! Is it a real issue though? We could argue the implementation of ERC20WrapperBundler is not compatible with non-reverting ERC20Wrapper implementations and it could be fine. do we know of wrappers that don't revert and instead return false?

Indeed we could say that

We are a couple of weeks away from deployment

*days btw

@Rubilmax
Copy link
Collaborator

Indeed we could say that

In which case i would suggest introducing a comment instead (which is fine), ideally before contract verification to also have it displayed on Etherscan

MerlinEgalite
MerlinEgalite requested changes Dec 28, 2023
View reviewed changes
src/libraries/ErrorsLib.sol Outdated Show resolved Hide resolved
src/ERC20WrapperBundler.sol Outdated Show resolved Hide resolved
src/ERC20WrapperBundler.sol Outdated Show resolved Hide resolved
@Jean-Grimal @MerlinEgalite
Apply suggestions from code review
7d68f81 
Co-authored-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com>
Signed-off-by: Jean-Grimal <83286814+Jean-Grimal@users.noreply.github.com>
MathisGD
MathisGD approved these changes Dec 28, 2023
View reviewed changes
src/libraries/ErrorsLib.sol Show resolved Hide resolved
@MerlinEgalite MerlinEgalite merged commit 5203ca9 into main Dec 28, 2023
8 checks passed
@MerlinEgalite MerlinEgalite deleted the fix/issue-600 branch December 28, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathisGD MathisGD MathisGD approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@QGarchery QGarchery Awaiting requested review from QGarchery QGarchery was automatically assigned from morpho-org/onchain-reviewers

@adhusson adhusson Awaiting requested review from adhusson

@Rubilmax Rubilmax Awaiting requested review from Rubilmax

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jean-Grimal @MerlinEgalite @Rubilmax @adhusson @MathisGD