Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leftover paths and pre-commit hook #464

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

adhusson
Copy link
Contributor

@adhusson adhusson commented Nov 5, 2024

some paths were not updated (I do not know why compilation still worked)

in addition, the change to husky's pre-commit applied forge fmt to files and left them in the working directory. I replaced it with lint:fix.

Copy link
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wtf, the compilation seems to work anyway

Copy link
Contributor

@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it has to do with caching or something like that :/

@adhusson
Copy link
Contributor Author

adhusson commented Nov 6, 2024

Should be fixed soon foundry-rs/foundry#9274

@MathisGD MathisGD merged commit 1fa1725 into main Nov 6, 2024
16 checks passed
@MathisGD MathisGD deleted the chore/finish-sdk-removal branch November 6, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants