perf wExp
#12
Merged
perf wExp
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathisGD
requested review from
a team,
Rubilmax,
MerlinEgalite,
Jean-Grimal,
QGarchery and
peyha
and removed request for
a team
QGarchery
requested changes
Sep 4, 2023
QGarchery
reviewed
Sep 4, 2023
Jean-Grimal
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
I'm in favor of this implementation. It's way more readable than #11 and I also think that this method is very smart.
|
Ok so I was doing 2 mistakes:
I fixed and tested both |
QGarchery
reviewed
Sep 4, 2023
MathisGD
force-pushed
the
perf/wExp-2
branch
from
0d8bc22
to
42bb1a0
Compare
|
New snapshot (but the test have changed) 
|
Jean-Grimal
approved these changes
Sep 4, 2023
MerlinEgalite
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5. second alternative for an optimized wExp (range reduction + low order Taylor), much simpler.
the reason why it is more efficient than the other one is probably because the Taylor order is low, meaning that it is not very precise but I think that it is enough for what we do.