fixed rate irm #123
Merged
fixed rate irm #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhusson
reviewed
Jan 26, 2024
MathisGD
commented
Jan 27, 2024
MathisGD
commented
Jan 27, 2024
MathisGD
commented
Jan 27, 2024
MerlinEgalite
previously approved these changes
Feb 10, 2024
adhusson
approved these changes
Feb 10, 2024
QGarchery
reviewed
Feb 12, 2024
Rubilmax
reviewed
Feb 12, 2024
MathisGD
dismissed stale reviews from Jean-Grimal and MerlinEgalite
via
bab3be0
Rubilmax
previously approved these changes
Feb 19, 2024
QGarchery
previously approved these changes
Feb 19, 2024
Jean-Grimal
previously approved these changes
Feb 19, 2024
MerlinEgalite
previously approved these changes
Feb 19, 2024
Co-authored-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com> Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
natspec in interface
MathisGD
dismissed stale reviews from MerlinEgalite, Jean-Grimal, QGarchery, and Rubilmax
via
f926397
bound (fixed) rate
MerlinEgalite
approved these changes
Mar 5, 2024
MerlinEgalite
requested changes
Mar 5, 2024
Rubilmax
approved these changes
Mar 5, 2024
not anymore :-) (weird rounding in adaptive curve irm when fuzzing that i can't reproduce locally, but not impact). Will open an issue to investigate |
QGarchery
approved these changes
Mar 5, 2024
Jean-Grimal
approved these changes
Mar 5, 2024
MerlinEgalite
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed rate IRM for Morpho Blue. Anybody can set the rate for a market but it can be set only once. Typical use case is that the market creator batches the creation of the market with the fixed rate IRM with the setting of the rate they want for it on the IRM.
Note that this IRM probably doesn't make sense alone, as a lending pool with fixed IRM faces illiquidity risks. It will be used to experiment with different stuff like terms on blue.
This IRM makes market creators vulnerable to a griefing attack: for an oracle, you can set the rate for all the markets that make sense with this oracle, making these markets that could have been created in the future ususable. Meaning that now to create a market with the same pair of assets (with a different LLTV for example) you might have to re-deploy the oracle because a malicious actor could have set the rate already.