Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use only int256 #69

Merged
merged 13 commits into from
Nov 14, 2023
Merged

Use only int256 #69

merged 13 commits into from
Nov 14, 2023

Conversation

MathisGD
Copy link
Contributor

No description provided.

Rubilmax
Rubilmax reviewed Nov 10, 2023
View reviewed changes
Copy link
Contributor

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest only 2 changes to keep uint256 in 2 places with justifications that the result is indeed >= 0, instead of moving these justifications and duplicate them everytime we case the result outside of _borrowRate

src/SpeedJumpIrm.sol Show resolved Hide resolved
src/SpeedJumpIrm.sol Show resolved Hide resolved
QGarchery
QGarchery reviewed Nov 10, 2023
View reviewed changes
src/SpeedJumpIrm.sol Show resolved Hide resolved
src/SpeedJumpIrm.sol Show resolved Hide resolved
src/SpeedJumpIrm.sol Show resolved Hide resolved
src/SpeedJumpIrm.sol Show resolved Hide resolved
Rubilmax
Rubilmax reviewed Nov 10, 2023
View reviewed changes
src/SpeedJumpIrm.sol Outdated Show resolved Hide resolved
@MathisGD MathisGD marked this pull request as ready for review November 11, 2023 07:59
Rubilmax
Rubilmax reviewed Nov 11, 2023
View reviewed changes
src/SpeedJumpIrm.sol Outdated Show resolved Hide resolved
src/SpeedJumpIrm.sol Outdated Show resolved Hide resolved
src/SpeedJumpIrm.sol Outdated Show resolved Hide resolved
MerlinEgalite
MerlinEgalite reviewed Nov 11, 2023
View reviewed changes
Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem ok but I don't think this change was necessary and it can introduce unexpected consequences at the last minute.

I'd be in favor of not introducing them

src/SpeedJumpIrm.sol Outdated Show resolved Hide resolved
@MerlinEgalite
Copy link
Contributor

formatting issue

@MerlinEgalite
Copy link
Contributor

can you wait before merging it @MathisGD please?

QGarchery
QGarchery approved these changes Nov 13, 2023
View reviewed changes
src/SpeedJumpIrm.sol Show resolved Hide resolved
@QGarchery QGarchery mentioned this pull request Nov 13, 2023
Merged
MerlinEgalite
MerlinEgalite approved these changes Nov 14, 2023
View reviewed changes
src/SpeedJumpIrm.sol Outdated Show resolved Hide resolved
src/SpeedJumpIrm.sol Outdated Show resolved Hide resolved
QGarchery
QGarchery requested changes Nov 14, 2023
View reviewed changes
src/SpeedJumpIrm.sol Show resolved Hide resolved
src/libraries/MathLib.sol Show resolved Hide resolved
@MathisGD @MerlinEgalite
docs: minor improvements
006384a 
Co-authored-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com>
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
@MathisGD MathisGD merged commit 8483911 into refactor/curve Nov 14, 2023
3 checks passed
@MathisGD MathisGD deleted the refactor/int branch November 14, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@QGarchery QGarchery QGarchery approved these changes

@Rubilmax Rubilmax Awaiting requested review from Rubilmax

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MathisGD @MerlinEgalite @Rubilmax @QGarchery @Jean-Grimal