-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(irm): add ping tests #80
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubilmax
requested review from
QGarchery,
MerlinEgalite,
MathisGD and
Jean-Grimal
November 15, 2023 14:41
Pb with the CI |
Jean-Grimal
previously approved these changes
Nov 15, 2023
…eriphery into test/rates-test
Rubilmax
force-pushed
the
test/rates-test
branch
from
November 15, 2023 17:14
37dfee6
to
30496ec
Compare
Rubilmax
force-pushed
the
test/rates-test
branch
from
November 16, 2023 08:26
944bdce
to
3fbeaf1
Compare
QGarchery
reviewed
Nov 16, 2023
QGarchery
previously approved these changes
Nov 16, 2023
MerlinEgalite
approved these changes
Nov 16, 2023
…-periphery into test/rates-test
MerlinEgalite
previously approved these changes
Nov 16, 2023
MerlinEgalite
dismissed stale reviews from QGarchery, Jean-Grimal, and themself
November 16, 2023 18:43
The base branch was changed.
MerlinEgalite
approved these changes
Nov 16, 2023
MathisGD
reviewed
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.