Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trapezoidal (n=2) #91

Merged
merged 7 commits into from
Nov 16, 2023
Merged

Trapezoidal (n=2) #91

merged 7 commits into from
Nov 16, 2023

Conversation

MathisGD
Copy link
Contributor

No description provided.

@QGarchery QGarchery mentioned this pull request Nov 16, 2023
Closed
@MerlinEgalite MerlinEgalite requested review from a team, Rubilmax, MerlinEgalite, Jean-Grimal, QGarchery and peyha and removed request for a team November 16, 2023 17:14
Jean-Grimal
Jean-Grimal approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@Jean-Grimal Jean-Grimal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very clean

QGarchery
QGarchery reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I have a way to make it a bit more concise, opening a PR on top

src/SpeedJumpIrm.sol Outdated Show resolved Hide resolved
peyha
peyha approved these changes Nov 16, 2023
View reviewed changes
Copy link

@peyha peyha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The calcul is correct for me

Rubilmax
Rubilmax approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure all these detailed comments are necessary to be frank, but they are obviously welcomed to make the review the easiest

@MerlinEgalite MerlinEgalite merged commit 089da66 into feat/riemann-avg Nov 16, 2023
3 checks passed
@MerlinEgalite MerlinEgalite deleted the feat/trapezoidal branch November 16, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@peyha peyha peyha approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@QGarchery QGarchery QGarchery approved these changes

@Rubilmax Rubilmax Rubilmax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MathisGD @Rubilmax @QGarchery @MerlinEgalite @peyha @Jean-Grimal