docs(oracle): clarify SCALE_FACTOR def #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubilmax
requested review from
QGarchery,
MerlinEgalite,
MathisGD and
Jean-Grimal
Rubilmax
commented
Oct 27, 2023
MerlinEgalite
previously approved these changes
Oct 30, 2023
QGarchery
requested changes
Oct 30, 2023
|
I addressed most of your comments @QGarchery but I really think that spacing eases reading equations in comments (with no dedicated typography) ^^ |
QGarchery
requested changes
Oct 30, 2023
There was a problem hiding this comment.
I really think that spacing eases reading equations in comments
Ok no blocker for me on that particular topic, but here it was also used to group things together in a coherent way. I think too many parentheses is confusing (and there was a mistake in the equations because of that)
Looks good, only a few fixes left to do
QGarchery
previously approved these changes
Oct 30, 2023
MerlinEgalite
previously approved these changes
Oct 30, 2023
|
@Jean-Grimal @MathisGD can you review please? |
|
@Rubilmax can you update it please? |
Rubilmax
dismissed stale reviews from MerlinEgalite and QGarchery
via
e6e38d7
Rubilmax
force-pushed
the
fix/rubilmax
branch
from
e6e38d7
to
25c4ab6
Compare
MerlinEgalite
approved these changes
Nov 9, 2023
|
pb with the token 🥲 |
|
@Rubilmax can you update this PR please? |
MerlinEgalite
approved these changes
Nov 11, 2023
MathisGD
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.