feat(ifc): add interfaces #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubilmax
requested review from
QGarchery,
MerlinEgalite,
MathisGD and
Jean-Grimal
QGarchery
requested changes
Nov 29, 2023
QGarchery
reviewed
Nov 29, 2023
Rubilmax
force-pushed
the
feat/interfaces
branch
from
3bcf7c5
to
bd47170
Compare
QGarchery
approved these changes
Nov 29, 2023
MerlinEgalite
approved these changes
Nov 29, 2023
MathisGD
approved these changes
Dec 4, 2023
| IERC4626 public immutable VAULT; | ||
| /// @notice Vault conversion sample. The sample amount of shares used to convert to the underlying asset. | ||
| /// @notice Should be chosen such that converting `VAULT_CONVERSION_SAMPLE` to assets has enough precision. | ||
|
|
There was a problem hiding this comment.
😁 pls someone help me protect spaced storage
There was a problem hiding this comment.
as you want, I approved anyway
| uint256 public immutable VAULT_CONVERSION_SAMPLE; | ||
| /// @notice First base feed. | ||
|
|
| AggregatorV3Interface public immutable BASE_FEED_1; | ||
| /// @notice Second base feed. | ||
|
|
| AggregatorV3Interface public immutable BASE_FEED_2; | ||
| /// @notice First quote feed. | ||
|
|
| AggregatorV3Interface public immutable QUOTE_FEED_1; | ||
| /// @notice Second quote feed. | ||
|
|
| AggregatorV3Interface public immutable QUOTE_FEED_2; | ||
| /// @notice Price scale factor, computed at contract creation. | ||
|
|
|
@Jean-Grimal can you review it please? |
Jean-Grimal
approved these changes
Dec 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.