Heap tests improvement #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makcandrov
force-pushed
the
tests-improvement
branch
from
2bb28f8 to
2f702c2
Compare
Co-authored-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com>
pakim249CAL
reviewed
May 5, 2023
MerlinEgalite
previously approved these changes
May 6, 2023
|
can you update the certora part please? or maybe @QGarchery |
|
The Certora part fails due to #126 (base of this branche) |
makcandrov
requested review from
QGarchery,
Tristan22400,
MerlinEgalite,
pakim249CAL and
MathisGD
Tristan22400
previously approved these changes
May 9, 2023
QGarchery
previously approved these changes
May 9, 2023
If I can batch all Certora changes in one go that would be easier for me. Is that ok ? |
This reverts commit bae0e19.
makcandrov
changed the base branch from
feature/partition-tests
to
code-style-change
MerlinEgalite
dismissed stale reviews from QGarchery, Tristan22400, and themself
via
bd4ecfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion #122, this PR improves the tests of the BasicHeap, by implementing fuzzing and making them less dependent on the heap's actual implementation.
I took the opportunity to change the functions fuzzed in
TestThreeHeapOrderingInvariantbecause the previous implementation almost always inserted new accounts. Now, it can insert, increase, decrease, and remove with correct probabilities.I did not refactor the tests of other data structures because it would have required a huge amount of work (maybe left for another time).