revert on non enabled markets #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathisGD
requested review from
MerlinEgalite,
adhusson,
QGarchery,
Rubilmax and
Jean-Grimal
Rubilmax
previously approved these changes
Feb 29, 2024
QGarchery
previously approved these changes
Feb 29, 2024
adhusson
previously approved these changes
Feb 29, 2024
Jean-Grimal
reviewed
Feb 29, 2024
|
I think that you should also add a check that prevents calling this function with an empty |
Rubilmax
approved these changes
Mar 1, 2024
Rubilmax
approved these changes
Mar 1, 2024
QGarchery
approved these changes
Mar 1, 2024
StErMi
reviewed
Mar 4, 2024
Jean-Grimal
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/cantinasec/review-morpho/issues/16
Fixes https://github.com/cantinasec/review-morpho/issues/21 (2 and 4)