Implement support for category-specific querying: cars. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A 'utils' folder helps with separation of concerns. Moved some utility functions to this folder to keep main file more organised. This required to remove all the global invocations of the following variables: * queries * dbFile * apiCredentials Finally, added utils function for checking the price against the user-defined minPrice and maxPrice.
Introduce check of query criteria against product details by moving the check for price against minPrice and maxPrice in dedicated function. This will make code future-proof, as it will allow to define multiple criteria checks, rather than only the price.
Introduce support black-listing keywords as an additional filtering method for users. TODO: Implement possibility to let users add keywords from CMD, rather than hardcoding them in the .py file
Cars ads have more details than other items. Specifically, cars ads have the following information: * conditions of car (new/used) * date of registration * km * fueling type (petrol, diesel, hybrid, etc.) * gearing (manual, automatic) * euro-emission This means that type-specific implementation is needed for this category of products. Add arg flags to specify the km and registration date query criteria. Add BLACKLIST list for cars, and support for including it in the blacklisting check. Add utils for car-specific functions.
|
Hi, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce specific search options and functions for car querying.
Cars Ads have more details than other ads. Specifically, cars ads have the following information which other ads dont have:
* conditions of car (new/used)
* date of registration
* km
* fueling type (petrol, diesel, hybrid, etc.)
* gearing (manual, automatic)
* euro-emission
This means that ad-category-specific implementation is required to support querying for this category of products.
Additionally, some fixes and changes were made along the way.