Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add eval after all to mosaicmllogger #3496

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ethanma-db
Copy link
Contributor

@ethanma-db ethanma-db commented Jul 26, 2024

What does this PR do?

Add eval after all event to the mosaicmllogger to pass to Mapi. This should only trigger if there is some executing evaluator:

def _run_evaluators(self, event: Event):

Adding from this doc:
https://docs.google.com/document/d/1Rk43aTNFXIUULs0OvTMQGXrV8bJkITmjICyGmMrF2Zc/edit?usp=sharing

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@ethanma-db ethanma-db marked this pull request as ready for review July 26, 2024 16:30
@ethanma-db ethanma-db requested a review from a team as a code owner July 26, 2024 16:30
Copy link
Contributor

@b-chu b-chu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

composer/loggers/mosaicml_logger.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants