Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump pytorch to 2.5.0 #3663

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Bump pytorch to 2.5.0 #3663

merged 1 commit into from
Oct 21, 2024

Conversation

b-chu
Copy link
Contributor

@b-chu b-chu commented Oct 19, 2024 •
edited
Loading

What does this PR do?

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@b-chu b-chu mentioned this pull request Oct 19, 2024
Open
7 tasks
@b-chu b-chu marked this pull request as ready for review October 19, 2024 01:10
@b-chu b-chu requested review from a team as code owners October 19, 2024 01:10
@b-chu b-chu mentioned this pull request Oct 19, 2024
Closed
7 tasks
@b-chu b-chu force-pushed the spr/main/ee8a3a5d branch 4 times, most recently from 151b691 to 6cbd82b Compare October 19, 2024 02:12
@b-chu
Bump pytorch to 2.5.0
5a0ff63 
commit-id:ee8a3a5d
@b-chu b-chu force-pushed the spr/main/ee8a3a5d branch from 6cbd82b to 5a0ff63 Compare October 19, 2024 02:17
@b-chu b-chu requested review from bigning and mvpatel2000 October 21, 2024 14:41
@b-chu b-chu merged commit 835dd76 into main Oct 21, 2024
58 of 64 checks passed
@b-chu b-chu deleted the spr/main/ee8a3a5d branch October 21, 2024 14:47
snarayan21
snarayan21 reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't have to go in this PR, but would like to add transformer engine as an optional dep so we can remove from dockerfiles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snarayan21 snarayan21 snarayan21 left review comments

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

@bigning bigning Awaiting requested review from bigning

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@b-chu @mvpatel2000 @snarayan21