Fix netifaces install in Dockerfile #3726
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
netifaces pip package is broken / empty on ubuntu 22.04 install for non-aws images, then bpt tries to install it but it fails since the pip package already exists. we install it properly in this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix netifaces install in Dockerfile
What issue(s) does this change relate to?
The research team reported that in their inference deployments this line of code installs an empty, unimportable netifaces pip package. We fix this by uninstalling the empty pip package and reinstalling the correct pip package.
Tests
import netifaces✅No module named netifaces✅