Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max_new_tokens to MPT handler #396

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add max_new_tokens to MPT handler #396

wants to merge 3 commits into from

Conversation

ajaysaini725
Copy link
Contributor

Let's use max_new_tokens and mark max_length as deprecated - it's much clearer

bcui19
bcui19 approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@bcui19 bcui19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Glabred Glabred Glabred approved these changes

@bcui19 bcui19 bcui19 approved these changes

@sakshigupta93 sakshigupta93 sakshigupta93 approved these changes

@margaretqian margaretqian Awaiting requested review from margaretqian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajaysaini725 @sakshigupta93 @bcui19 @Glabred