Custom Exceptions for Mosaic Logger #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
reviewed
Mar 6, 2024
jjanezhang
force-pushed
the
jane/add-ft-error-handling
branch
from
4eae0fd
to
b9ec456
Compare
|
I could move the new conversation chat tests to the |
irenedea
reviewed
Mar 13, 2024
irenedea
approved these changes
Mar 14, 2024
irenedea
reviewed
Mar 20, 2024
jjanezhang
force-pushed
the
jane/add-ft-error-handling
branch
from
9380f90
to
eba4f74
Compare
jjanezhang
force-pushed
the
jane/add-ft-error-handling
branch
from
d754c73
to
244d98d
Compare
KuuCi
pushed a commit
that referenced
this pull request
Apr 18, 2024
* flagged areas to throw ft errors + added custom exception * added exceptions for all files * fixed type of invalid type errors * fixed merge * added exceptions for all files * fixed merge * added a catch for missing hf url * expain dataloader catch to all error types * added tests for custom exceptions * fixed a couple tests * fixed some more tests * addressed comments * fixed formatting, updated split correction, moved logger setup into helper * added check for repeating roles * more strict checking for prompt response type * removed some cases we don't need * updated name of unknown conversation type error * formatting * Fix multi model eval (#1055) * resolved merge conflict * formatted * added back two imports * formatting changes * formatted again * sorted imports * diable yapf for exceptions import * disabled yapf on test dataloader --------- Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates custom exceptions to label all user solvable errors in the finetuning run path. Logs exceptions in these areas using the MosaicML logger.
Manually tested by running ft yaml with missing train split.
Dependent on: mosaicml/composer#3089