Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Models registry #1057

Merged
merged 12 commits into from
Mar 25, 2024
Merged

Models registry #1057

merged 12 commits into from
Mar 25, 2024

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented Mar 24, 2024 •
edited
Loading

Round of manual tests:

  • MPT pretrain before and after (registry-condition-mpt-1-YoWX7j vs registry-baseline-mpt-1-gTfymO)
  • llama finetune before and after (registry-condition-llama-1-qxchzh vs registry-baseline-llama-1-eYIlHX)
  • multi model eval before and after (registry-condition-eval-1-dXlla3 vs registry-baseline-eval-1-9Csev8)

@dakinggg dakinggg marked this pull request as ready for review March 24, 2024 21:49
@dakinggg dakinggg mentioned this pull request Mar 25, 2024
Merged
irenedea
irenedea approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@irenedea irenedea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! some minor things

llmfoundry/utils/warnings.py Outdated Show resolved Hide resolved
llmfoundry/utils/warnings.py Show resolved Hide resolved
llmfoundry/utils/builders.py Outdated Show resolved Hide resolved
llmfoundry/utils/builders.py Show resolved Hide resolved
llmfoundry/models/inference_api_wrapper/interface.py Show resolved Hide resolved
@dakinggg dakinggg merged commit 2d65fc2 into mosaicml:main Mar 25, 2024
9 checks passed
KuuCi pushed a commit that referenced this pull request Apr 18, 2024
@dakinggg @KuuCi
Models registry (#1057)
9cb8d19
@dakinggg dakinggg deleted the models-registry branch June 22, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irenedea irenedea irenedea approved these changes

@mvpatel2000 mvpatel2000 Awaiting requested review from mvpatel2000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dakinggg @irenedea