Update config_moe_args.py #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://databricks.atlassian.net/browse/GRT-2812 see [here](https://github.com/mosaicml/llm-foundry-private/pull/245#issuecomment-2046306845) Ran 500 steps, new version did marginally better
mvpatel2000
approved these changes
Apr 10, 2024
vchiley
added a commit
to vchiley/composer
that referenced
this pull request
Apr 10, 2024
Porting mosaicml/llm-foundry#1104 to composer.
7 tasks
vchiley
added a commit
to mosaicml/composer
that referenced
this pull request
Apr 10, 2024
Porting mosaicml/llm-foundry#1104 to composer.
vchiley
added a commit
that referenced
this pull request
Apr 12, 2024
Merged
vchiley
added a commit
that referenced
this pull request
Apr 12, 2024
staghado
pushed a commit
to lightonai/composer
that referenced
this pull request
Apr 13, 2024
Porting mosaicml/llm-foundry#1104 to composer.
staghado
pushed a commit
to lightonai/composer
that referenced
this pull request
Apr 13, 2024
Porting mosaicml/llm-foundry#1104 to composer.
KuuCi
pushed a commit
that referenced
this pull request
Apr 18, 2024
https://databricks.atlassian.net/browse/GRT-2812 see [here](https://github.com/mosaicml/llm-foundry-private/pull/245#issuecomment-2046306845) Ran 500 steps, new version did marginally better
KuuCi
pushed a commit
that referenced
this pull request
Apr 18, 2024
KuuCi
pushed a commit
that referenced
this pull request
Apr 18, 2024
j316chuck
pushed a commit
to mosaicml/composer
that referenced
this pull request
May 16, 2024
Porting mosaicml/llm-foundry#1104 to composer.
passiondev2024
added a commit
to passiondev2024/llm-foundry
that referenced
this pull request
Oct 25, 2024
mosaicml/llm-foundry#1111 needed to revert mosaicml/llm-foundry#1104 because the #1104 PR caused issues. Removing TODO and marking Jira with wont-do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
create_process_group_ranksfn withdistributed.new_groupsee here
Ran 500 steps, new version did marginally better