Fix saving of generation_config for Llama-3 #1134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing version of
HuggingFaceCheckpointer
does not respect model'sgeneration_config.json
and during saving it initializes it from theconfig.json
. In the case of Llama-3 model, there is a discrepancy witheos_token_id
which is set to128001
inconfig.json
but to[128001, 128009]
ingeneration_config.json
. This means that Llama-3 models saved withHuggingFaceCheckpointer
have"eos_token_id": 128001
instead of"eos_token_id": [128001, 128009],
.This creates problems when we want to use Llama-3 models produced with llm-foundry as they will most likely always generate text until the max number of tokens is exhausted instead of stopping at
128009
token.