fix DatasetConstants.splints default value to protect dictionary overwriting #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ples amount; correct type hinting for raw_samples
ivan-kud
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The values of
DatasetConstants.splintsdictionary of "c4" dataset overwrites the values for the "The Pile" splits dictionary. This is because the dict type ofDatasetConstants.splintsdefault value is mutable, sodefault_factoryshould be used.Also there are typos for
train_smallamount of raw samples.And I correct type hinting for
DataSplitConstants.raw_samples. TheNonevalue is checked below in the code.