Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing dependency group #1287

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Add missing dependency group #1287

merged 3 commits into from
Jun 17, 2024

Conversation

dakinggg
Copy link
Collaborator

The Composer mlflow dependency group contains more than just mlflow, so we need to install the whole dep group.

@dakinggg dakinggg requested a review from a team as a code owner June 14, 2024 22:53
@dakinggg dakinggg enabled auto-merge (squash) June 14, 2024 22:53
@dakinggg dakinggg requested a review from a team as a code owner June 14, 2024 23:08
snarayan21
snarayan21 reviewed Jun 14, 2024
View reviewed changes
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we create a separate optional dep group in composer that contains only what foundry needs? or does foundry need all of the packages under 'mlflow'?

@dakinggg
Copy link
Collaborator Author

@snarayan21 foundry needs the whole dep group

snarayan21
snarayan21 approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm then

@dakinggg dakinggg disabled auto-merge June 14, 2024 23:41
@dakinggg dakinggg enabled auto-merge (squash) June 14, 2024 23:41
@dakinggg dakinggg merged commit f8b2875 into mosaicml:main Jun 17, 2024
10 of 11 checks passed
@dakinggg dakinggg deleted the db-dep branch June 22, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snarayan21 snarayan21 snarayan21 approved these changes

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dakinggg @mvpatel2000 @snarayan21