Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Retries to run_query #1302

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Add Retries to run_query #1302

merged 4 commits into from
Jun 24, 2024

Conversation

KuuCi
Copy link
Contributor

@KuuCi KuuCi commented Jun 24, 2024

Fine-tuning has seen a couple of failures regarding Spark timing out, resulting in complete run failure. Just adding retries here to buffer and hopefully reduce that down.

https://databricks.atlassian.net/browse/MCLOUD-4793

Here is a passing run:
test-uc-mlflow-66pcq4

@KuuCi KuuCi marked this pull request as ready for review June 24, 2024 12:12
@KuuCi KuuCi requested a review from a team as a code owner June 24, 2024 12:12
@KuuCi KuuCi requested a review from dakinggg June 24, 2024 12:12
Copy link
Collaborator

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we make it a decorator or helper fn?

scripts/data_prep/convert_delta_to_json.py Outdated Show resolved Hide resolved
@KuuCi
Copy link
Contributor Author

KuuCi commented Jun 24, 2024

Passing Run: test-uc-mlflow-WyKSz4

@KuuCi KuuCi merged commit fd7b187 into main Jun 24, 2024
11 checks passed
@dakinggg dakinggg deleted the retry_delta_to_json branch August 6, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants