Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor hf checkpointer for config transformations #1318

Merged
merged 2 commits into from
Jun 29, 2024
Merged

Refactor hf checkpointer for config transformations #1318

merged 2 commits into from
Jun 29, 2024

Conversation

irenedea
Copy link
Contributor

@irenedea irenedea commented Jun 29, 2024 •
edited
Loading

Subclasses can now easily extend the config transformations by overriding the transform_config method.

@irenedea irenedea requested a review from a team as a code owner June 29, 2024 01:15
@irenedea irenedea requested a review from dakinggg June 29, 2024 01:17
dakinggg
dakinggg approved these changes Jun 29, 2024
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, simple unit test for the helper method since its a public method now would be good, but not blocking

@irenedea irenedea enabled auto-merge (squash) June 29, 2024 19:06
@irenedea irenedea merged commit 88511f7 into mosaicml:main Jun 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irenedea @dakinggg