Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre register method for mlflow #1396

Merged
merged 5 commits into from
Jul 26, 2024
Merged

Add pre register method for mlflow #1396

merged 5 commits into from
Jul 26, 2024

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented Jul 26, 2024 •
edited
Loading

Adds a new method to allow subclasses to modify the saved files before registering to mlflow.

@dakinggg dakinggg marked this pull request as ready for review July 26, 2024 19:16
@dakinggg dakinggg requested a review from a team as a code owner July 26, 2024 19:16
@dakinggg dakinggg changed the title add Add pre register method for mlflow Jul 26, 2024
irenedea
irenedea approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@irenedea irenedea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dakinggg dakinggg enabled auto-merge (squash) July 26, 2024 22:26
@dakinggg dakinggg merged commit 0c93331 into mosaicml:main Jul 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irenedea irenedea irenedea approved these changes

@snarayan21 snarayan21 Awaiting requested review from snarayan21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dakinggg @irenedea