Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log original config #1410

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Log original config #1410

merged 4 commits into from
Jul 31, 2024

Conversation

josejg
Copy link
Contributor

@josejg josejg commented Jul 29, 2024

Follow-up to #1351. This PR changes the logging behavior to log the originally submitted config. The current behavior applies transformations, then merges them into the original config. Because of the merging, the logged config might not be a valid config, making reproducible runs harder.

@josejg josejg requested a review from a team as a code owner July 29, 2024 22:31
@dakinggg dakinggg merged commit f670108 into mosaicml:main Jul 31, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants