[WIP] Torch 2.4 in docker images #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvpatel2000
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
@dakinggg to decide if we want to remove old ones, I think yes
|
@mvpatel2000 we do in 3 stages: (1) add the new images and bump the max pin, (2) add the new CI and make sure it passes, (3) bump the min pin and remove the older version |
irenedea
reviewed
Aug 28, 2024
snarayan21
changed the title
…h/docker_img_torch_bump merging.
snarayan21
force-pushed
the
saaketh/docker_img_torch_bump
branch
from
368bf21
to
d8da0ad
Compare
dakinggg
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds torch 2.4 docker images.
Also reverts ci-testing to v0.1.2 so that dependencies are not automatically upgraded by uv.
Passing GPU tests (manual run): https://github.com/mosaicml/llm-foundry/actions/runs/10640011732