Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation warning to fsdp_config #1530

Merged
merged 16 commits into from
Sep 17, 2024
Merged

Add deprecation warning to fsdp_config #1530

merged 16 commits into from
Sep 17, 2024

Conversation

KuuCi
Copy link
Contributor

@KuuCi KuuCi commented Sep 16, 2024 •
edited
Loading

Deprecates fsdp_config and replaces it with parallelism_config. Replaces all instances of the test, as well as new unit tests to make sure that the proper warnings are thrown when users attempt to use fsdp_config

@KuuCi KuuCi marked this pull request as ready for review September 16, 2024 22:17
@KuuCi KuuCi requested a review from a team as a code owner September 16, 2024 22:17
@KuuCi KuuCi requested a review from dakinggg September 16, 2024 22:40
dakinggg
dakinggg reviewed Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add unit tests for calling this function with the different args and make sure the expected outcomes happen?

@KuuCi KuuCi requested a review from dakinggg September 17, 2024 18:43
mvpatel2000
mvpatel2000 reviewed Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR descriptions are your friend

@KuuCi KuuCi merged commit 2e3d14f into main Sep 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

@snarayan21 snarayan21 Awaiting requested review from snarayan21

@dakinggg dakinggg Awaiting requested review from dakinggg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KuuCi @mvpatel2000 @snarayan21 @dakinggg