Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate Cluster Access Mode #1551

Merged
merged 15 commits into from
Sep 25, 2024
Merged

Validate Cluster Access Mode #1551

merged 15 commits into from
Sep 25, 2024

Conversation

KuuCi
Copy link
Contributor

@KuuCi KuuCi commented Sep 25, 2024 •
edited
Loading

To resolve:
https://databricks.atlassian.net/browse/ES-1264005
Basically this error happens if the cluster access mode is not either Single User or Shared

Testing:
image

image

@KuuCi KuuCi requested a review from a team as a code owner September 25, 2024 21:33
@KuuCi KuuCi requested a review from dakinggg September 25, 2024 21:33
dakinggg
dakinggg reviewed Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you do a new manual test confirming the update still works?

@KuuCi @dakinggg
Update llmfoundry/command_utils/data_prep/convert_delta_to_json.py
8f06e7e 
Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
@KuuCi KuuCi enabled auto-merge (squash) September 25, 2024 22:30
@KuuCi KuuCi merged commit e6b8d14 into main Sep 25, 2024
9 checks passed
@KuuCi KuuCi mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KuuCi @dakinggg