Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update StreamingDataset defaults #157

Merged
merged 2 commits into from
May 18, 2023
Merged

Update StreamingDataset defaults #157

merged 2 commits into from
May 18, 2023

Conversation

abhi-mosaic
Copy link
Contributor

  • Change default shuffle_algo to py1b rather than py1s
  • Add support for shuffle_block_size defaulted to 1 << 18 ~= 256k

@abhi-mosaic abhi-mosaic self-assigned this May 17, 2023
alextrott16
alextrott16 approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@alextrott16 alextrott16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@abhi-mosaic abhi-mosaic merged commit e5a9692 into main May 18, 2023
@hanlint hanlint deleted the abhi/streaming_defaults branch May 26, 2023 19:49
bmosaicml pushed a commit that referenced this pull request Jun 6, 2023
@abhi-mosaic
Fix LLM mcloud convert commands (#157)
e507ab5
bmosaicml pushed a commit that referenced this pull request Jun 6, 2023
@abhi-mosaic
add py1b, shuffle_block_size (#157)
a2cbaa6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextrott16 alextrott16 alextrott16 approved these changes

Assignees

@abhi-mosaic abhi-mosaic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhi-mosaic @alextrott16